Repository navigation
feat: add Q7 remote control trait - #1039
Open
ramon-angosto wants to merge 2 commits into
Open
ramon-angosto wants to merge 2 commits into
ramon-angosto wants to merge 2 commits into
Conversation
Add `clean_zone` and `clean_zones` to the Q7 properties API. Zones are given as two opposite corners in the common Roborock millimetre coordinate space through a new `Q7RoborockPoint`, which converts to and from the Q7 world coordinates (meters, origin next to the dock). The device expects the zone preference type to be selected first (`service.set_preference_type`), then the zone corners as a flat list (`service.set_zone_points`), and finally `service.set_zone_clean` to start. Several zones are concatenated into a single task.
Add a `RemoteTrait` to the Q7 properties API, mirroring the Q10 remote API. Manual mode is entered with `prop.set sweep_type=5` and the robot is driven with `service.set_direction` (1 forward, 2 left, 3 right, 0 exit). Each command moves the robot for a short burst, so callers repeat it while a direction is held. Leaving remote mode restores `sweep_type=0`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Q7PropertiesApi.remote(RemoteTrait), mirroring the Q10 remote API:stop()enters manual mode and holds the robot in place.forward(),left(),right()move the robot.exit_remote()leaves manual mode.New
Q7RemoteDirectionenum for the direction codes.Device protocol
prop.set {"sweep_type": 5}enters manual mode. The device then reportswork_mode2.service.set_direction {"direction": n}moves the robot: 1 forward, 2 turn left, 3 turn right, 0 exit.prop.set {"sweep_type": 0}.The official app only offers forward, left and right; there is no backward.
Testing
roborock.vacuum.sc05, firmware 03.01.80).